Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task/WG-237-Delete-Project-Modal-React #273

Merged
merged 16 commits into from
Nov 9, 2024
Merged

task/WG-237-Delete-Project-Modal-React #273

merged 16 commits into from
Nov 9, 2024

Conversation

sophia-massie
Copy link
Contributor

@sophia-massie sophia-massie commented Oct 16, 2024 •
edited
Loading

Overview:

Create delete project modal, delete hook, and delete project tests

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  • Adds DeleteProjectModal component with corresponding hook, style sheet, and tests
  • Adds a generic useDelete hook in requests

Testing Steps:

  1. Go to project listing page. All projects should have active trash icons.
  2. If a map is not able to be deleted, there will be a message in the modal rather than disabling the trash icon.

UI Photos:

Project listing shows all active trash icons

Screenshot 2024-10-29 at 7 16 40 PM

If a map can't be deleted

Screenshot 2024-10-29 at 7 17 34 PM

If a map can be deleted and is not public

Screenshot 2024-10-29 at 7 17 02 PM

If a map can be deleted and is public

Screenshot 2024-10-29 at 7 21 10 PM

If there is an error deleting a map

Screenshot 2024-10-29 at 7 18 51 PM

If deleting a map was successful

Screenshot 2024-10-29 at 7 19 35 PM

Notes:

nathanfranklin
nathanfranklin requested changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and works well 💯 🦖

Just some comments:

  • on messaging differences related to the angular version
  • and some general code change suggestions to be considered (feel free to to or ignore depending on what you think).

react/src/types/projects.ts Show resolved Hide resolved
react/src/components/DeleteMapModal/DeleteMapModal.tsx Outdated Show resolved Hide resolved
react/src/__fixtures__/projectFixtures.ts Outdated Show resolved Hide resolved
react/src/__fixtures__/projectFixtures.ts Show resolved Hide resolved
react/src/components/Projects/ProjectListing.tsx Outdated Show resolved Hide resolved
react/src/components/DeleteMapModal/DeleteMapModal.tsx Outdated Show resolved Hide resolved
react/src/components/DeleteMapModal/DeleteMapModal.tsx Outdated Show resolved Hide resolved
react/src/components/Projects/ProjectListing.tsx Outdated Show resolved Hide resolved
react/src/components/DeleteMapModal/DeleteMapModal.tsx Outdated Show resolved Hide resolved
react/src/components/DeleteMapModal/DeleteMapModal.tsx Outdated Show resolved Hide resolved
nathanfranklin
nathanfranklin approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

left two comments to consider.

@sophia-massie sophia-massie merged commit f5767b2 into main Nov 9, 2024
5 checks passed
@sophia-massie sophia-massie deleted the task/WG-237-Delete-Project-Modal-React branch November 9, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanfranklin nathanfranklin nathanfranklin approved these changes

@taoteg taoteg Awaiting requested review from taoteg

@shayanaijaz shayanaijaz Awaiting requested review from shayanaijaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophia-massie @nathanfranklin